Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tx-submission decision logic for the inbound side #3311

Open
3 tasks
coot opened this issue Sep 1, 2021 · 1 comment · May be fixed by #4887
Open
3 tasks

tx-submission decision logic for the inbound side #3311

coot opened this issue Sep 1, 2021 · 1 comment · May be fixed by #4887
Assignees
Labels
tx-submission Issues related to tx-submission protocol

Comments

@coot
Copy link
Contributor

coot commented Sep 1, 2021

To smooth traffic and save bandwidth, we can add a decision logic to inbound
tx-submission protocol which would decide from whom to download an available
transaction and trace which transactions are being downloaded (so we don't
start to download something that's already being downloaded).

todo list

  • validate tx size
  • validate that tx size is smaller than maximum tx size
  • efficient adding txs to mempool (do not try add the same tx twice)
    Is this even needed? Mempool could check txids before doing any expensive validation.
@coot coot added networking tx-submission Issues related to tx-submission protocol labels Sep 1, 2021
@dcoutts
Copy link
Contributor

dcoutts commented Sep 1, 2021

This would be a design change with the following benefits:

  1. substantially reduced bandwidth for tx broadcast
  2. smoothing out refilling of the mempool to reduce bursty CPU and network use

This will be a useful optimisation as we get towards higher and higher chain throughput / TPS. For the moment (at current low TPS rates) it is not a significant issue. The effects are only visible in benchmarks with very high TPS.

@coot coot removed the networking label Dec 18, 2023
@coot coot changed the title tx-submission decision logic on inbound side tx-submission decision logic for the inbound side Dec 20, 2023
@coot coot self-assigned this Jan 11, 2024
@coot coot linked a pull request Jun 4, 2024 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tx-submission Issues related to tx-submission protocol
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

2 participants