-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redeemers serialization fixes #4040
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
force-pushed
the
lehins/redeemers-serialization-fixes
branch
2 times, most recently
from
February 2, 2024 15:59
b33ea61
to
8c7edc4
Compare
teodanciu
reviewed
Feb 2, 2024
teodanciu
reviewed
Feb 2, 2024
teodanciu
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
4 tasks
* Allow list decoding for backwards compatibility
lehins
force-pushed
the
lehins/redeemers-serialization-fixes
branch
from
February 2, 2024 21:35
8c7edc4
to
b57d92c
Compare
rooooooooob
added a commit
to dcSpark/cardano-multiplatform-lib
that referenced
this pull request
Mar 28, 2024
Includes: * IntersectMBO/cardano-ledger#4003 * IntersectMBO/cardano-ledger#4178 * IntersectMBO/cardano-ledger#4055 * IntersectMBO/cardano-ledger#4117 * IntersectMBO/cardano-ledger#4040 TODO: [ ] need to check how this affects the script data hash and test that [ ] multi-era
SebastienGllmt
pushed a commit
to dcSpark/cardano-multiplatform-lib
that referenced
this pull request
May 1, 2024
* New Conway.cddl updates (cml-chain/cml-chain-wasm) Includes: * IntersectMBO/cardano-ledger#4003 * IntersectMBO/cardano-ledger#4178 * IntersectMBO/cardano-ledger#4055 * IntersectMBO/cardano-ledger#4117 * IntersectMBO/cardano-ledger#4040 TODO: [ ] need to check how this affects the script data hash and test that [ ] multi-era * conway multi-era update + various fixes * resolve merge conflict * use conway costmodels for all eras (babbage costmdls found in alonzo on sancho testnet) * IntoIter for NonemptySet<T>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses part of the #3922 ticket, namely switched redeemers to use Map encoding by default
It also fixes CDDL for Conway PParams
Extra nice cleanup is addition of Map conversion functions and deprecation of
keyBy
Checklist
.cabal
andCHANGELOG.md
files according to theversioning process.
.cabal
files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.md
for the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)