Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Plutus deps to 1.22.1.0 #681

Merged
merged 7 commits into from
Feb 26, 2024
Merged

Bump Plutus deps to 1.22.1.0 #681

merged 7 commits into from
Feb 26, 2024

Conversation

Unisay
Copy link
Contributor

@Unisay Unisay commented Feb 26, 2024

No description provided.

From https://github.com/intersectmbo/plutus at 79cb92bbc82c0b4a08585e170dc381cb1c3ba24c
From https://github.com/intersectmbo/plutus at 79cb92bbc82c0b4a08585e170dc381cb1c3ba24c
From https://github.com/intersectmbo/plutus at 79cb92bbc82c0b4a08585e170dc381cb1c3ba24c
From https://github.com/intersectmbo/plutus at 79cb92bbc82c0b4a08585e170dc381cb1c3ba24c
@Unisay Unisay self-assigned this Feb 26, 2024
@Unisay Unisay marked this pull request as ready for review February 26, 2024 10:50
@Unisay Unisay requested a review from lehins February 26, 2024 11:04
@lehins
Copy link
Contributor

lehins commented Feb 26, 2024

Are you sure it should not have been 1.23.0?

The reason why I am saying is that the constraint in ledger plutus-ledger-api ^>= 1.22 will no longer work, because 1.22.1 contains a breaking change

@michaelpj
Copy link
Contributor

We're going to deprecate 1.22.0. Perhaps we should just go to 1.23, I'm not sure 🤔

@lehins
Copy link
Contributor

lehins commented Feb 26, 2024

We're going to deprecate 1.22.0.

Interesting. Is there support in CHaPs for deprecating packages package versions/releases?

@michaelpj
Copy link
Contributor

Yes. I need to add a section to the readme but see an example here:

@michaelpj
Copy link
Contributor

Note that this does "cabal-style deprecations", which is to say it makes them non-preferred, so the solver can still pick them if it has no other options (I wish it emitted a warning in this case...).

@Unisay
Copy link
Contributor Author

Unisay commented Feb 26, 2024

I've added the deprecations for 1.22.0.0

@Unisay Unisay merged commit b105fcc into IntersectMBO:main Feb 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants