-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import cardano addresses repo #492
base: master
Are you sure you want to change the base?
Conversation
379e81b
to
1c6b3e4
Compare
aa66568
to
6a44437
Compare
70ddc39
to
6a44437
Compare
f0c7d10
to
6d867d6
Compare
Branch before rebasing: https://github.com/IntersectMBO/cardano-base/tree/backup/import-cardano-addresses-repo |
Commit: aa66568 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh my god! 😮 +42K lines of code. cardano-addresses
is bigger than the whole of cardano-base
repo right now.
We need to seriously discuss the future of cardano-addresses
, because I am no longer sure that embedding it into any other repo is a good idea.
Looking at all of the changes in this PR and the massive size of cardano-addresses
makes me realize that this is just not going to work.
This PR integrates the repo https://github.com/IntersectMBO/cardano-addresses in https://github.com/IntersectMBO/cardano-base.
This PR:
cardano-addresess
repo (the pattern is using the name of the cabal file/project as folder inside):core
->cardano-addresses/cardano-addresses
command-line
->cardano-addresses/cardano-addresses-cli
jsapi
->cardano-addresses/cardano-addresses-jsapi
jsbits
->cardano-addresses/cardano-addresses-jsbits
cardano-cli
executable (e.g:.#docker.x86_64-linux.cardano-address
).ghcjs
cross-compilationghcjs
cross-compilation except for those incardano-addresses
, because they weren't compiling.cardano-addresses-js
:.#cardano-addresses-js
.#cardano-addresses-demo-js
.#cardano-addresses-js-shell
cardano-addresses-jsbits
called.#jsbits
, because it seemed quite necessary for following theREADME.md
s injsapi
andjsbits
.cardano-addresses
code to make it compatible with ghc above9.8.2
, some required having someCPP
directives.Considerations:
jsapi
tests are disabled except forghcjs
, I think they are only meant to work on JSREADME.md
s, and I moved the one in the root to thecardano-addresses
subdir.musl
outputs, or any artifact generation. Happy to do them in another PR (or even partially in this one).cardano-addresses
the haddock is not in the top level index because there are more things deployed: demo app and js doc. I haven't migrated either, it would require to move thecardano-base
a level higher. Happy to do that in another PR.ghcjs-overlay
, needs to be updated periodically forcabal build
to work withoutnix
, this is done with an action currently. This is important for the CI action that caches the CodeSpaces. Don't know how the CI action is triggered, may need credentials.input-output-hk
repo for documentation. Presumably that requires credentials to manage too.cardano-addresses
libraries from this repo, I think it is necessary to cut a new version of the library and add it to CHaP. I have never done a CHaP release, but probably makes sense to do it in a separate PR.hjsonschema
library for versions ofghc
greater than9.8.2
, because it doesn't compile and is deprecated. It seems this only affects a test which is still being run on the other versions of ghc, so it is not a problem yet. Also, it was already disabled forghcjs
.