Generalized mlocking via MonadST #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
approved these changes
May 18, 2023
cardano-crypto-class/src/Cardano/Crypto/Libsodium/Memory/Internal.hs
Outdated
Show resolved
Hide resolved
tdammers
force-pushed
the
tdammers/just-use-monad-st
branch
from
1c1fdfb
to
7374962
Compare
lehins
requested changes
May 23, 2023
cardano-crypto-class/src/Cardano/Crypto/Libsodium/Memory/Internal.hs
Outdated
Show resolved
Hide resolved
tdammers
force-pushed
the
tdammers/just-use-monad-st
branch
2 times, most recently
from
20f2fe3
to
1e67222
Compare
Changes: - Remove MonadSodium typeclass - Express mlocked memory operations in terms of MonadST - Get rid of ForgetMock testing (has been moot since we no longer depend on GC to reclaim mlocked memory) - Remove `m` parameter from mlocked memory based typeclasses (KES, DSIGN) - Simplify KES and DSIGN typeclass hierarchies
tdammers
force-pushed
the
tdammers/just-use-monad-st
branch
from
00c4e4e
to
4ee7879
Compare
lehins
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative approach to generalizing mlocking allocations over "arbitrary" monads (specifically, we want
IOandIOSim).#388 introduces a
MonadMLocktypeclass, in much the same way asio-classesprovidesMonadMVar,MonadDelay, etc.; this PR takes a different approach, based on the observation that all the mlocked allocation and raw memory manipulation APIs, while technically inIO, are morally inST- their only effects are memory manipulations, there's no I/O going on, no randomness, etc. So we provide versions of all those primitives and FFI functions inST(or rather, with aMonadSTconstraint), which automatically makes them available inIOandIOSim.One complication of this is that we cannot use the
MonadMLocktypeclass to inject mlock allocation logging, like we did in #388; we solve this by changing the relevant APIs such that they take an explicitMLockedAllocatorargument, and API-backards-compatible convenience wrappers that default the allocator tomlockedMalloc. And now we can implement mlocked allocation logging by passing a "decorated" allocator (which not only allocates, but also logs the allocation, and attaches deallocation logging code to the finalizer), while using the compatible wrappers outside of testing.