Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeInferenceProvider raises if empty cache is provided #475

Closed
lisroach opened this issue Apr 5, 2021 · 2 comments
Closed

TypeInferenceProvider raises if empty cache is provided #475

lisroach opened this issue Apr 5, 2021 · 2 comments

Comments

@lisroach
Copy link
Contributor

lisroach commented Apr 5, 2021

Per: Instagram/Fixit#31 (comment)

TypeInferenceProvider raises when cache is {}.

Fixing this bug will allow us to remove the PLACEHOLDER_CACHES and neaten up the code in Fixit.
This was referenced Apr 5, 2021
Closed
Merged
@mir-am
Copy link

mir-am commented Apr 8, 2021

In my code, I managed to fix the TypeInferenceProvider breakage by passing {'types':[]} to cache .
Thanks for fixing the issue.

@lisroach
Copy link
Contributor Author

lisroach commented Apr 8, 2021

In my code, I managed to fix the TypeInferenceProvider breakage by passing {'types':[]} to cache .

That's what I've been doing too, this fix should make for some cleaner code now :)

@lisroach lisroach closed this as completed Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mir-am @lisroach