Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Praise Participants pattern #710

Merged
merged 6 commits into from
Aug 24, 2024
Merged

Conversation

semioticrobotic
Copy link
Contributor

This pull request suggests several changes to the Praise Participants pattern. In particular, it:

  • Converts all instances of inner source to InnerSource in order to maintain the book's style and ensure consistency
  • Offers several line edits to enhance readability

Copy link

welcome bot commented Aug 19, 2024

Thank You Banner

💖 Thanks for opening this pull request! 💖 The InnerSource Commons community really appreciates your time and effort to contribute to the project. Please make sure you have read our Contributing Guidelines.

If you are submitting a new pattern, the following things will help get your pull request across the finish line! 🏁

  • Confirm that you have used our pattern template. Please remove any placeholder text and sections that your pattern did not need.
  • We run a number of automated checks on your PR. Please review the output of those checks on the PR itself, and see if any issues got flagged that you can fix yourself.
  • Make sure you have added your new pattern to the list of patterns in the main README.md. If you are unsure where to add your pattern, just let us know by commenting on your PR and we will help you.

This project has a small number of maintainers, volunteering their time to this project. So please be patient and we will get back to you as soon as we can. If we don't acknowledge this pull request after 7 days, feel free to chat to us about it in our Slack workspace.

@spier spier added 2-structured Patterns with existing instances (Please see our contribution handbook for details) 📖 Type - Content Work Working on contents is the main focus of this issue / PR labels Aug 22, 2024
Copy link
Member

@spier spier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@semioticrobotic thank you for reading our patterns, and for helping to make them better.

I left a couple of comments with questions where I did not understand the suggested changes.

Btw you will be pleased to know that in the meantime we have automatic checks that will spot wrong spellings of InnerSource to keep consistency in our book :) (these checks only run once any of the patterns is touched though)

patterns/2-structured/praise-participants.md Show resolved Hide resolved
patterns/2-structured/praise-participants.md Show resolved Hide resolved
patterns/2-structured/praise-participants.md Show resolved Hide resolved
Edit two more sentences in response to editorial feedback
…"qualified" was removed in the pattern itself.
Copy link
Member

@spier spier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great now!

I left one last comment for your review, and after that we can get this live in our book 🥳

patterns/2-structured/praise-participants.md Outdated Show resolved Hide resolved
@semioticrobotic
Copy link
Contributor Author

This looks great now!

I left one last comment for your review, and after that we can get this live in our book 🥳

Everything looks fine to me! Thanks for considering my contribution and for your collaboration!

@spier spier merged commit bed6958 into InnerSourceCommons:main Aug 24, 2024
9 checks passed
Copy link

welcome bot commented Aug 24, 2024

Congratulations Banner
Congrats on merging your first pull request! 🎉 We here at The InnerSource Commons are proud of you! 💖 Thank you so much for your contribution 🎁

@spier
Copy link
Member

spier commented Aug 24, 2024

Thank you for the quick feedback @semioticrobotic.

Your changes are now live at https://patterns.innersourcecommons.org/p/praise-participants

I should have asked this earlier but how did you come across our patterns book and this pattern in particular? Maybe you know other orgs practicing this pattern? If so, we could add these to the "Known Instances" section.

And lastly, if you want to chat with other InnerSource enthusiasts, you can come join us in https://innersourcecommons.org/slack

Thanks again for improving the readability and style consistency of this pattern!

@semioticrobotic
Copy link
Contributor Author

Great! Thanks so much.

I am helping develop the InnerSource practice at SAS and was re-reading patterns this week. As I continue, I'll file additional editorial suggestions.

@spier
Copy link
Member

spier commented Aug 25, 2024

Great! Thanks so much.

I am helping develop the InnerSource practice at SAS and was re-reading patterns this week. As I continue, I'll file additional editorial suggestions.

That's cool. I think we have not referenced SAS in any of our patterns yet, so even just knowing if and how you are implementing any of these patterns at SAS would already help a lot to harden the quality of our patterns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2-structured Patterns with existing instances (Please see our contribution handbook for details) 📖 Type - Content Work Working on contents is the main focus of this issue / PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants