Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small readability updates #184

Merged
merged 2 commits into from
Jul 30, 2020
Merged

Conversation

jpatrao
Copy link
Contributor

@jpatrao jpatrao commented Jul 21, 2020

Small readability updates. Because a certain paragraph within the solution section was not clear to me ... and I guess to others too, I did rework it. Closer attention needs to be paid here because I did not intend to change the meaning of what was written.

Small readability updates.
Copy link
Member

@spier spier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wording/grammar changes look good to me.

I added a question in the one paragraph where you tried to simplify the text. There I am not sure how it was meant by the original author.

start-as-experiment.md Show resolved Hide resolved
Copy link
Member

@lenucksi lenucksi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jpatrao, thanks for improving the phrasing and readability here! 🎉
I would merge but I'm agree with @spier on his comment which keeps me from insta-merging this.
Please take a look at the inline comment.

start-as-experiment.md Show resolved Hide resolved
@jpatrao
Copy link
Contributor Author

jpatrao commented Jul 29, 2020

@lenucksi @spier Please take a look at the revised edits from me.

@spier
Copy link
Member

spier commented Jul 29, 2020

@jpatrao I don't see any new edits or commits. Are you referring to your proposal in here?
https://github.com/InnerSourceCommons/InnerSourcePatterns/pull/184/files#r459058825

@jpatrao
Copy link
Contributor Author

jpatrao commented Jul 29, 2020

@jpatrao I don't see any new edits or commits. Are you referring to your proposal in here?
https://github.com/InnerSourceCommons/InnerSourcePatterns/pull/184/files#r459058825

@spier Yes.

Copy link
Member

@lenucksi lenucksi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the changes, this looks good to me right now :)

@lenucksi lenucksi merged commit c241f79 into InnerSourceCommons:master Jul 30, 2020
@spier
Copy link
Member

spier commented Jul 30, 2020

🎉

@lenucksi lenucksi added the 📖 Type - Content Work Working on contents is the main focus of this issue / PR label Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 Type - Content Work Working on contents is the main focus of this issue / PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants