Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make AiServices class global #7

Closed
InAnYan opened this issue May 27, 2024 · 0 comments · Fixed by #9
Closed

Make AiServices class global #7

InAnYan opened this issue May 27, 2024 · 0 comments · Fixed by #9
Labels
important-decision This issue contains an important architectural decision logic Logic related issue

Comments

@InAnYan
Copy link
Owner

InAnYan commented May 27, 2024

AiService class is responsible for managing the AI connection and storing document's embeddings.

This class also connects to AiPreference to check for other updates.

The object of this class should remain global, live for every session of JabRef.

Currently, AiService lives in AiChatTab (or actually I have even moved it to EntryEditor). This is not right, because objects of this class reset on library change.
This was referenced May 27, 2024
Closed
Merged
@InAnYan InAnYan added help wanted logic Logic related issue important-decision This issue contains an important architectural decision and removed help wanted labels May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
important-decision This issue contains an important architectural decision logic Logic related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make AiService global InAnYan/jabref
Make AiService global InAnYan/jabref
1 participant
@InAnYan