Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please review commits to Forked version of master Branch #59

Open
bhapps opened this issue Apr 20, 2019 · 0 comments
Open

Please review commits to Forked version of master Branch #59

bhapps opened this issue Apr 20, 2019 · 0 comments

Comments

@bhapps
Copy link

bhapps commented Apr 20, 2019

@ImangazalievM below for your review/rejection/advice

Thank you for contributing to ReActiveAndroid. Before pressing the "Create Pull Request" button, please consider the following points:

Please give a description about what and why you are contributing, even if it's trivial.

  • Added API Fuctionality for Transactions & Pagination with sample activites (and subsequent adapters, layouts, menus, values, manifest) within reactiveandroid\sample-app

  • For review by repository owner

  • Review at bhapps@b40e96c

Please include the issue list number(s) or other PR numbers in the description if you are contributing in response to those.

Please include a reasonable set of unit tests if you contribute new code or change an existing one.

  • None added, but provided within reactiveandroid\sample-app
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant