Check for negative value when printing prompt connection #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this PR! Great bug catch 😄 It's probably simpler to use |
|
Oh wait, that was stupid of me, let me test if that even works 😅 |
|
Yah no that was just me being an idiot, your way is right 😂 I'll get this merged. |
No worries! Thought I missed something as well and tested it just in case 👍 |
IlanCosman
approved these changes
Mar 10, 2021
|
gah CI being annoying, gotta get that fixed first :( |
|
Thanks for contributing @mfossen 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
applies to issue #120
Check for a negative value before printing prompt connection to avoid issues with
string repeat.Motivation and Context
Closes #120
Screenshots (if appropriate)
How Has This Been Tested
This looks like it fixes the issue when I add it on both Linux and MacOS.
Checklist