Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix softmax operator in onnx2nnoir #213

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Fix softmax operator in onnx2nnoir #213

merged 2 commits into from
Jun 26, 2024

Conversation

maejima-fumika
Copy link
Contributor

Change

  • Change default value check for axis param.
  • Add negative value check for axis param.

@maejima-fumika
Copy link
Contributor Author

以下のバグを修正しました。
https://www.notion.so/35517f7aca794f1d8f002aa1aa572333?pvs=4#71ae3e6291194570bcd3920c11e2c6fc

@maejima-fumika maejima-fumika merged commit 90f22e3 into master Jun 26, 2024
6 checks passed
@maejima-fumika maejima-fumika deleted the fix-softmax branch June 26, 2024 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishiy1993 ishiy1993 ishiy1993 approved these changes

@garasubo garasubo Awaiting requested review from garasubo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maejima-fumika @ishiy1993