Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pause / unpause container #69

Closed
wants to merge 4 commits into from
Closed

Conversation

acidghost
Copy link

Closes #68

@acidghost
Copy link
Author

acidghost commented Oct 30, 2019

@eldesh Not sure why this is failing. All non-ignored tests pass locally on my machine (OSX).

@eldesh eldesh added the reviewing Reviewing, wait a moment label Oct 31, 2019
@eldesh
Copy link
Collaborator

eldesh commented Oct 31, 2019

@acidghost export_load_image test also use alpine:latest image. So it conflicts to pause_unpause_container because these test cases are performed in parallel. Please use a unique image.

@eldesh eldesh added wontfix This will not be worked on and removed reviewing Reviewing, wait a moment labels Oct 31, 2019
@acidghost
Copy link
Author

acidghost commented Oct 31, 2019

I see the problem. Would not be better to change the CI configuration to run test sequentially? It should be a matter of removing the -j option passed to cargo test (https://github.com/eldesh/dockworker/blob/master/.circleci/config.yml#L63).

If it is okay with you, I can make the change: open new PR to solve #70 and then, merge the change in this PR.

@eldesh
Copy link
Collaborator

eldesh commented Oct 31, 2019

cargo test performs in parallel by default. So, if -j option is removed, #70 would not be solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for container pause / unpause
2 participants