Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of comments in the code #11

Open
MrGranddy opened this issue Jun 29, 2023 · 0 comments
Open

Lack of comments in the code #11

MrGranddy opened this issue Jun 29, 2023 · 0 comments

Comments

@MrGranddy
Copy link

Hello, thank you very much for the contribution to the community.

You've done an impressive work and lots of people are probably trying to implement your method for their own work.
It is very nice that you share the code, so that we can check the 'not so clear' parts in the paper.

Yet even I see that you've applied many smart tricks and I probably can imagine the state you are in while writing the code,
it would be very nice if you add some comments to the code. Currently it is like an ancient codex that needs to be cracked,
I will probably crack it faster then waiting for an update but for people in the future, please consider adding comments.
This code is one of the most cryptic I saw in the field, which is normal considering the nature of the problem, creating something
new almost always breaks mainstream frameworks.

Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant