Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MCX simulation reflection flag -b #337

Open
RecurvedBow opened this issue Jul 2, 2024 · 5 comments
Open

Add MCX simulation reflection flag -b #337

RecurvedBow opened this issue Jul 2, 2024 · 5 comments
Assignees
Labels
feature New feature or request

Comments

@RecurvedBow
Copy link
Collaborator

Please describe your 🚀 feature request.
Add the -b / --reflect flag to the MCX simulation without breaking any existing reflectance behavior (https://mcx.space/wiki/index.cgi?Doc/mcx_help).

Describe the solution you'd like
Update the MCXAdapter to accept a boolean flag whether the photons should be reflected or transmitted at the simulation borders.

@RecurvedBow RecurvedBow added the feature New feature or request label Jul 2, 2024
@RecurvedBow RecurvedBow self-assigned this Jul 2, 2024
@RecurvedBow RecurvedBow changed the title Add MCX simulation reflection flag Add MCX simulation reflection flag -b Jul 2, 2024
@RecurvedBow
Copy link
Collaborator Author

Will only apply reflection on the volume faces along the x-axis and z-axis

@RecurvedBow
Copy link
Collaborator Author

Since there are multiple possible behaviors, will define an enum instead of a boolean flag instead. Will include: default, fresnel reflection, mirror reflection, cyclic

@kdreher
Copy link
Collaborator

kdreher commented Jul 3, 2024

This issue is related to #286 and we'll wait until that one is resolved :)

@leoyala
Copy link
Collaborator

leoyala commented Jul 3, 2024

This could also be resolved by #311 since user-defined flags could be passed and would overwrite the default ones.

@RecurvedBow
Copy link
Collaborator Author

I have found out that the command flags for capturing reflectance are set incorrectly: we do not need --saveref; and there is actually a bug with saving photon direction and position on exit. I will address the first case in this issue, and add the second as a bug issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants