Metrics with status unknown in the details view of the 'Metrics' metr…

components/frontend/package-README.md

@@ -0,0 +1,4 @@
+# README package.json
+
+The package.json contain a devDependency for @babel/core to prevent memory problems when running the front end unit tests on CircleCI. See this issue: https://github.com/facebook/create-react-app/issues/8096.
+

components/frontend/package.json

@@ -36,6 +36,7 @@
   "devDependencies": {
     "enzyme": "^3.11.0",
     "enzyme-adapter-react-16": "^1.15.2",
-    "react-test-renderer": "^16.12.0"
+    "react-test-renderer": "^16.12.0",
+    "@babel/core": "^7.7.7"
   }
 }

components/frontend/src/metric/StatusIcon.js

@@ -1,12 +1,12 @@
 import React from 'react';
 import { Icon } from 'semantic-ui-react';
 
-export function StatusIcon({ status}) {
-    const status_icon = {
-      target_met: 'check', near_target_met: 'warning', debt_target_met: 'money',
-      target_not_met: 'x', null: 'question'
-    }[status];
-    return (
-      <Icon size='large' name={status_icon} />
-    )
+export function StatusIcon({ status }) {
+  const status_icon = {
+    target_met: 'check', near_target_met: 'warning', debt_target_met: 'money',
+    target_not_met: 'x', null: 'question'
+  }[status || null];
+  return (
+    <Icon size='large' name={status_icon} />
+  )
 }

components/frontend/src/metric/StatusIcon.test.js

@@ -1,9 +1,14 @@
 import React from 'react';
-import ReactDOM from 'react-dom';
+import { mount } from 'enzyme';
 import { StatusIcon } from './StatusIcon';
 
-it('renders without crashing', () => {
-  const div = document.createElement('div');
-  ReactDOM.render(<StatusIcon status="target_met" />, div);
-  ReactDOM.unmountComponentAtNode(div);
-});
+describe('<StatusIcon/>' , () => {
+  it('renders a checkmark if the status is target_met', () => {
+    const wrapper = mount(<StatusIcon status="target_met" />);
+    expect(wrapper.find("Icon").prop("name")).toBe("check");
+  })
+  it('renders a question mark if the status is missing', () => {
+    const wrapper = mount(<StatusIcon/>);
+    expect(wrapper.find("Icon").prop("name")).toBe("question");
+  })
+})

docs/CHANGELOG.md

@@ -32,6 +32,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - Fix Checkmarx landing url. Fixes [#919](https://github.com/ICTU/quality-time/issues/919).
 - Remove plaintext passwords from HTML. Fixes [#921](https://github.com/ICTU/quality-time/issues/921).
 - Remove private tokens from URLs logged by the collector. Fixes [#934](https://github.com/ICTU/quality-time/issues/934).
+- Metrics with status unknown in the details view of the 'Metrics' metric did not show a question mark. Fixes [#935](https://github.com/ICTU/quality-time/issues/935).
 
 ## [1.2.0] - [2019-12-10]