Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the share buttons to the headers. #9016

Merged

Conversation

fniessink
Copy link
Member

Remove the share tabs for reports, subjects, and metrics and move the share button to the report, subject, and metric headers.

Closes #8821.

@fniessink fniessink linked an issue Jun 19, 2024 that may be closed by this pull request
3 tasks
@fniessink fniessink force-pushed the 8821-make-share-tab-a-copy-button-in-the-metric-header branch 4 times, most recently from 213bd0d to 9fb7f09 Compare June 19, 2024 21:22
@fniessink fniessink marked this pull request as ready for review June 19, 2024 21:22
@fniessink fniessink requested a review from wkoot June 19, 2024 21:23
Copy link
Contributor

@wkoot wkoot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, so many deletions! I couldn't quickly see where it got moved to until I saw the changes to PermLinkButton :D

Remove the share tabs for reports, subjects, and metrics and move the share button to the report, subject, and metric headers.

Closes #8821.
@fniessink fniessink force-pushed the 8821-make-share-tab-a-copy-button-in-the-metric-header branch from 9fb7f09 to 639c70a Compare June 20, 2024 18:13
@fniessink fniessink enabled auto-merge (rebase) June 20, 2024 18:13
Copy link

sonarcloud bot commented Jun 20, 2024

@fniessink fniessink merged commit acce5b6 into master Jun 20, 2024
41 checks passed
@fniessink fniessink deleted the 8821-make-share-tab-a-copy-button-in-the-metric-header branch June 20, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Share tab a copy button in the Metric header
2 participants