Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the login dialog, don't tell the user credentials are invalid when… #6538

Conversation

fniessink
Copy link
Member

… in fact the server couldn't be reached. Fixes #4704.

@fniessink fniessink marked this pull request as draft July 9, 2023 19:59
@fniessink fniessink force-pushed the 4704-when-a-user-tries-to-log-in-without-a-vpn-connection-qt-reports-invalid-credentials branch 2 times, most recently from 569daf3 to b5bc567 Compare July 9, 2023 20:32
@fniessink fniessink requested a review from wkoot July 9, 2023 21:13
@fniessink fniessink marked this pull request as ready for review July 9, 2023 21:13
@fniessink fniessink force-pushed the 4704-when-a-user-tries-to-log-in-without-a-vpn-connection-qt-reports-invalid-credentials branch from b5bc567 to a29a252 Compare July 11, 2023 12:17
@fniessink fniessink force-pushed the 4704-when-a-user-tries-to-log-in-without-a-vpn-connection-qt-reports-invalid-credentials branch from a29a252 to 9ecf9a4 Compare July 11, 2023 12:34
@sonarcloud
Copy link

sonarcloud bot commented Jul 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@fniessink fniessink merged commit f8d2577 into master Jul 11, 2023
@fniessink fniessink deleted the 4704-when-a-user-tries-to-log-in-without-a-vpn-connection-qt-reports-invalid-credentials branch July 11, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When a user tries to log in without a (VPN) connection, QT reports invalid credentials.
2 participants