Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for the strategies module. #1541

Merged
merged 2 commits into from
Oct 8, 2020

Conversation

fniessink
Copy link
Member

No description provided.

@fniessink fniessink requested a review from Cas-Ros October 8, 2020 09:11
self.assertEqual([["report1", 0]], reds_per_report(json))

def test_red_metrics(self):
"""Test that there the number of red metrics is returned."""
Copy link
Contributor

@Cas-Ros Cas-Ros Oct 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dit comment is onduidelijk. ik neem aan dat dit "Test that the number or red metrics is returned" moet zijn?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup.

@sonarcloud
Copy link

sonarcloud bot commented Oct 8, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@fniessink fniessink merged commit f90de2c into master Oct 8, 2020
@fniessink fniessink deleted the iks337-notifier-unit-tests branch October 8, 2020 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants