Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing Metrics Metric broken #3855

Closed
denniebouman opened this issue May 17, 2022 · 0 comments · Fixed by #3856
Closed

Missing Metrics Metric broken #3855

denniebouman opened this issue May 17, 2022 · 0 comments · Fixed by #3856
Assignees
@fniessink
Labels
Bug Something isn't working

Comments

@denniebouman
Copy link
Member

The Missing Metrics Metric has a keyerror:

Parse error
Traceback (most recent call last):
File "/home/collector/base_collectors/source_collector.py", line 147, in __safely_parse_source_responses
return await self._parse_source_responses(responses)
File "/home/collector/source_collectors/quality_time/missing_metrics.py", line 26, in _parse_source_responses
reports = await self._get_reports(reports_response)
File "/home/collector/source_collectors/quality_time/base.py", line 25, in _get_reports
reports = list(response_json["reports"])
KeyError: 'reports'

QT Version: 3.36.0
@denniebouman denniebouman added the Bug Something isn't working label May 17, 2022
@fniessink fniessink self-assigned this May 17, 2022
fniessink added a commit that referenced this issue May 17, 2022
@fniessink
When measuring the 'missing metrics' metric, *Quality-time* was still…
6ddcec7 
… using an old endpoint to get the data, resulting in a parse error. Fixes #3855.
@fniessink fniessink mentioned this issue May 17, 2022
Merged
@fniessink fniessink linked a pull request May 17, 2022 that will close this issue
When measuring the 'missing metrics' metric, *Quality-time* was still… #3856
Merged
fniessink added a commit that referenced this issue May 17, 2022
@fniessink
When measuring the 'missing metrics' metric, *Quality-time* was still…
a8e303c 
… using an old endpoint to get the data, resulting in a parse error. Fixes #3855.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fniessink fniessink

Labels
Bug Something isn't working
Projects
Quality-time backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

When measuring the 'missing metrics' metric, *Quality-time* was still… ICTU/quality-time
2 participants
@fniessink @denniebouman