Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OWASP dependency check XML filePath sometimes contains fileName and sometimes doesn't #1819

Closed
fniessink opened this issue Jan 10, 2021 · 0 comments · Fixed by #1820
Closed
Labels
Bug Something isn't working

Comments

@fniessink
Copy link
Member

This can cause Quality-time to consider different dependencies the same if the dependency has no hash.

@fniessink fniessink added the Bug Something isn't working label Jan 10, 2021
fniessink added a commit that referenced this issue Jan 10, 2021
…In those cases Quality-time would create a hash based on the file path of the dependency. However, file paths aren't necessarily unique across dependencies. Add the file name to the hash to make it unique. Fixes #1819.
fniessink added a commit that referenced this issue Jan 10, 2021
#1820)

Some dependencies in the OWASP Dependency Check report have no hash. In those cases Quality-time would create a hash based on the file path of the dependency. However, file paths aren't necessarily unique across dependencies. Add the file name to the hash to make it unique. Fixes #1819.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant