Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collector crashes when a report contains an unsupported source #1699

Closed
fniessink opened this issue Nov 26, 2020 · 0 comments · Fixed by #1703
Closed

Collector crashes when a report contains an unsupported source #1699

fniessink opened this issue Nov 26, 2020 · 0 comments · Fixed by #1703
Labels
Bug Something isn't working

Comments

@fniessink
Copy link
Member

If a source type becomes unsupported (i.e. there's no SourceCollector subclass to get the data from the source) and a report still contains a source with the unsupported source type, the collector will crash. The frontend doesn't have his problem, it will simply ignore unknown source types.

Possible solutions:

  • Remove unsupported source types from reports during start-up of the server
  • Replace unsupported source types with a "unsupported source" type during start-up of the server
  • Have the /internal-api/v3/metrics endpoint filter sources that are unsupported
  • Have the collector check that source types are supported before trying to instantiate a collector class for that type
@fniessink fniessink added the Bug Something isn't working label Nov 26, 2020
fniessink added a commit that referenced this issue Nov 28, 2020
fniessink added a commit that referenced this issue Nov 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant