Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove docker environment files #1063

Closed
fniessink opened this issue Feb 27, 2020 · 0 comments · Fixed by #1086
Closed

Remove docker environment files #1063

fniessink opened this issue Feb 27, 2020 · 0 comments · Fixed by #1086
Labels
Tech Technical change without significant user impact

Comments

@fniessink
Copy link
Member

fniessink commented Feb 27, 2020 •
edited
Loading

Now all components get all environment variables, which is not necessary and confusing.
@fniessink fniessink added the Tech Technical change without significant user impact label Feb 27, 2020
@fniessink fniessink changed the title Split docker environment files per component Remove docker environment files per component Mar 7, 2020
@fniessink fniessink changed the title Remove docker environment files per component Remove docker environment files Mar 7, 2020
fniessink added a commit that referenced this issue Mar 7, 2020
@fniessink
Remove environment env files. Improve docs. Closes #1063.
d3c768f
@fniessink fniessink mentioned this issue Mar 7, 2020
Merged
fniessink added a commit that referenced this issue Mar 7, 2020
@fniessink
Issue 1063 docker env files (#1086)
928b51f 
* Remove DEBUG environment variable.
* Add healthcheck to frontend container. 
* Pin Docker image versions. 
* Move environment variables to docker compose.
* Remove environment env files. 

Closes #1063.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Tech Technical change without significant user impact
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 1063 docker env files ICTU/quality-time
1 participant
@fniessink