Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to test for 3.12 (update packages if necessary) #44

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

Joao-L-S-Almeida
Copy link
Member

No description provided.

Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
@Joao-L-S-Almeida
Copy link
Member Author

Joao-L-S-Almeida commented Jul 8, 2024

Seemingly the toolkit is working for python 3.10, 3.11 and 3.12 using torch == 2.3.*, considering the flexible versions defined on requirements/required.txt, however, we could consider to use a discontinuous definition like torch<=2.1, >=2.3 if we observe some incompatibility.

@Joao-L-S-Almeida Joao-L-S-Almeida linked an issue Jul 8, 2024 that may be closed by this pull request
@Joao-L-S-Almeida Joao-L-S-Almeida self-assigned this Jul 8, 2024
@CarlosGomes98
Copy link
Collaborator

these requirements files should now really only be updated through accepting PRs from dependabot, and they should always have exactly pinned versions. For requirements like torch >= 2.1. we should add this instead in the pyproject.toml

@Joao-L-S-Almeida
Copy link
Member Author

Joao-L-S-Almeida commented Jul 18, 2024

The problem is that the automatic tests use these files to create the environment and the previously fixed versions have conflicts with python3.12.

@Joao-L-S-Almeida
Copy link
Member Author

Maybe we could create a kind of conditional for the requirements when switching between versions.

Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
@Joao-L-S-Almeida
Copy link
Member Author

Joao-L-S-Almeida commented Jul 19, 2024

I defined new fixed versions for the packages in requirements/required.txt based on the choices made automatically by Actions . It seems that is working for all the tests and python versions.

@romeokienzler
Copy link
Collaborator

lgtm - fix conflicts..then merge

Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
@Joao-L-S-Almeida
Copy link
Member Author

@carlos @romeokienzler The tests are now passing for 3.12, but they conflict with mmseg-related dependencies. I removed them and left them as optional for the user, that means, all the imports are conditional and hidden (using importlib) and it should not affect the general working.

Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating the supported Python versions to > 3.11
3 participants