Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/unet #67

Merged
merged 19 commits into from
Aug 20, 2024
Merged

Add/unet #67

merged 19 commits into from
Aug 20, 2024

Conversation

Joao-L-S-Almeida
Copy link
Member

Experimental draft to include support for mmsegmentation decoders.

Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
@Joao-L-S-Almeida Joao-L-S-Almeida self-assigned this Jul 31, 2024
Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
@Joao-L-S-Almeida Joao-L-S-Almeida linked an issue Aug 6, 2024 that may be closed by this pull request
Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>

Config file to test U-Net

Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>

mmsegmentation needs a special installation process

Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>

mmseg requires some extra dependencies

Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
@Joao-L-S-Almeida Joao-L-S-Almeida marked this pull request as ready for review August 7, 2024 18:32
Copy link
Collaborator

@romeokienzler romeokienzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

afaict lgtm

very clean code, low chance of breaking existing code

@romeokienzler
Copy link
Collaborator

@Michal-Muszynski
can you do a
git checkout add/unet
pip install --upgrade .

Then share your feedback please?

Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
@romeokienzler
Copy link
Collaborator

@Joao-L-S-Almeida to merge

@Joao-L-S-Almeida Joao-L-S-Almeida merged commit cbc98f1 into main Aug 20, 2024
1 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for U-net from mmseg in terratorch
2 participants