Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Global Tagging): re-gen service with latest API definition #47

Merged
merged 4 commits into from
Sep 30, 2020
Merged

fix(Global Tagging): re-gen service with latest API definition #47

merged 4 commits into from
Sep 30, 2020

Conversation

padamstx
Copy link
Member

@padamstx padamstx commented Sep 23, 2020 •
edited
Loading

PR summary

This PR contains:

  • a re-gen of the Global Tagging service
  • a renovation of the integration tests to more closely align with the current pattern being used for int tests
  • a new "examples" file which contains working examples of each operation (these can be used to produce an examples .json file which can be used in the production of the online reference apidocs)

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@padamstx padamstx self-assigned this Sep 23, 2020
@padamstx padamstx merged commit 356c4e1 into master Sep 30, 2020
@padamstx padamstx deleted the regen-tagging branch September 30, 2020 14:50
ibm-devx-automation pushed a commit that referenced this pull request Sep 30, 2020
@semantic-release-bot
chore(release): 0.11.2 release notes [skip ci]
c0ed859 
## [0.11.2](v0.11.1...v0.11.2) (2020-09-30)

### Bug Fixes

* **Global Tagging:** re-gen service with latest API definition ([#47](#47)) ([356c4e1](356c4e1))
@ibm-devx-automation
Copy link

🎉 This PR is included in version 0.11.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@padamstx padamstx

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@padamstx @ibm-devx-automation