Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimization - enable integer feature indexes #34

Open
abigailgold opened this issue May 11, 2022 · 0 comments
Open

minimization - enable integer feature indexes #34

abigailgold opened this issue May 11, 2022 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@abigailgold
Copy link
Member

In numpy typically columns are numbered using integers. Currently our implementation converts these into strings (i.e., '0', '1', etc.) in the returned generalizations. This is due to the bahavior of scikitlearn's OneHotEncoder which differs between integers and strings. But it would be better to leave these as integer keys to be consistent with numpy.
One workaround is to store in the beginning of the code a boolean stating whether the column indexes were received as integers, and at the end cast the strings back to integers in the return value.

@abigailgold abigailgold added the enhancement New feature or request label May 11, 2022
@abigailgold abigailgold added the good first issue Good for newcomers label Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant