Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determination page shows Uncaught TypeError in console #4144

Closed
bickelj opened this issue Sep 25, 2024 · 1 comment · Fixed by #4147
Closed

Determination page shows Uncaught TypeError in console #4144

bickelj opened this issue Sep 25, 2024 · 1 comment · Fixed by #4147
Labels
Type: Bug Bugs! Things that are broken :-/

Comments

@bickelj
Copy link
Contributor

bickelj commented Sep 25, 2024

Describe the bug

On the determination page, when looking in the JavaScript console (web developer tools) an error occurs when looking for a page element.

To Reproduce

  1. Using the sandbox db
  2. Visit determination page for submission, e.g. apply/submissions/2/determination/2/edit/
  3. Open developer tools, view JS console
  4. See the error:
Uncaught TypeError: proposal_form_field is null
    <anonymous> https://hypha.test/static/js/determination-template.js:53
    EventListener.handleEvent* https://hypha.test/static/js/determination-template.js:51
    <anonymous> https://hypha.test/static/js/determination-template.js:57

Expected behavior

No such error.

Priority

  • Low priority (annoying, would be nice to not see)

Affected roles

  • Developers

Screenshots

If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Trisquel 11.0
  • Browser: Abrowser (Firefox-ish) 128.0.3

Additional context

See #4142 (context in which issue was found) and #3425 (probable origin of issue).

I can't find an element with id id_proposal_form in current main at a5d3a4f or in the commit in #3425 that created the related JavaScript.

@bickelj bickelj added the Type: Bug Bugs! Things that are broken :-/ label Sep 25, 2024
@frjo
Copy link
Contributor

frjo commented Sep 25, 2024

We need to add a check to the js so see if the proposal field exists or not.

Thanks for noticing this bug and creating an issue for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Bugs! Things that are broken :-/
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants