Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disabledPlugins in hotswap-agent.properties does not work #442

Open
Mugenor opened this issue Oct 7, 2022 · 5 comments
Open

disabledPlugins in hotswap-agent.properties does not work #442

Mugenor opened this issue Oct 7, 2022 · 5 comments

Comments

@Mugenor
Copy link

Mugenor commented Oct 7, 2022

Hi

I'm using jbr-17 with HA and trying to disable unnecessary plugins via disabledPlugins in hotswap-agent.properties file, but plugins are not disabled.

hotswap-agent.properties file content:

disabledPlugins=Hibernate
LOGGER=debug

Expected result:
Hibernate plugin is disabled, e.g. it's not present in Discovered plugins log line or there is log about a ban for this plugin.

Actual result:
Hibernate plugin is not disabled (I see it in Discovered plugins log line + there is no logs about ban of the plugin) and a lot of debug logs (so the properties file is found and parsed).

Btw, jvm properties I'm using: -XX:+AllowEnhancedClassRedefinition -XX:HotswapAgent=fatjar

@skybber
Copy link
Contributor

skybber commented Oct 7, 2022

Did you try use external HA and -javaagent:hotswap-agent-1.4.2.jar=disablePlugin=Hibernate ?

@skybber
Copy link
Contributor

skybber commented Oct 7, 2022

If you require support in build-in HA, please write request at https://github.com/JetBrains/JetBrainsRuntime , there is no other way how to pass cmdline args to java agent other then agent=arg1=value1,arg2=value2.. . It could be doable using -XX:HotswapAgent=fatjar=arg1=value1,arg2=value2..., but we have to implement it.

@Mugenor
Copy link
Author

Mugenor commented Oct 7, 2022

Just tried your proposal:
it works, but it allows to disable only one plugin.
My goal is to disable all unnecessary plugins

@skybber
Copy link
Contributor

skybber commented Oct 7, 2022

Just use comma separated list as I wrote before.

@Mugenor
Copy link
Author

Mugenor commented Oct 7, 2022

It works, thank you!

This way I can solve my problem, but still, for me it looks like a bug that I can't disable plugins using properties file even though there is a special property exactly for this case. Are there plans for fixing it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants