Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for JDK 17 #404

Closed
achimmihca opened this issue Oct 5, 2021 · 2 comments
Closed

Support for JDK 17 #404

achimmihca opened this issue Oct 5, 2021 · 2 comments

Comments

@achimmihca
Copy link

JDK 17 has been released on 14 September 2021.
This is an LTS version such that HotswapAgent should support JDK 17.

There is a bundle of JDK11+HotswapAgent: https://github.com/TravaOpenJDK/trava-jdk-11-dcevm
Similarly, JDK17+HotswapAgent should be bundled.

@roeltje25
Copy link

I have this working using the jdk 17 from JetBrains (jbr_jcef-17-windows-x64-b135.1) and adding hotswapagent jar manually to lib/hotswap and running with the following options:
-XX:+AllowEnhancedClassRedefinition -javaagent:"D:\jbr_jcef-17-windows-x64-b135.1\lib\hotswap\hotswap-agent.jar"
--add-exports=java.base/sun.nio.ch=ALL-UNNAMED --add-exports=jdk.unsupported/sun.misc=ALL-UNNAMED --add-exports=jdk.unsupported/sun.reflect=ALL-UNNAMED --add-modules=java.se --add-exports=java.desktop/sun.awt=ALL-UNNAMED
--add-exports=java.naming/com.sun.jndi.ldap=ALL-UNNAMED
--add-opens=java.base/java.lang=ALL-UNNAMED
--add-opens=java.base/java.lang.invoke=ALL-UNNAMED
--add-opens=java.base/java.lang.reflect=ALL-UNNAMED
--add-opens=java.base/java.io=ALL-UNNAMED
--add-opens=java.base/java.security=ALL-UNNAMED
--add-opens=java.base/java.util=ALL-UNNAMED
--add-opens=java.base/java.util.concurrent=ALL-UNNAMED
--add-opens=java.management/javax.management=ALL-UNNAMED
--add-opens=java.naming/javax.naming=ALL-UNNAMED --add-exports=java.desktop/sun.awt=ALL-UNNAMED --add-exports=java.naming/com.sun.jndi.ldap=ALL-UNNAMED --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.lang.reflect=ALL-UNNAMED --add-opens=java.base/java.io=ALL-UNNAMED --add-opens=java.base/java.security=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.management/javax.management=ALL-UNNAMED --add-opens=java.naming/javax.naming=ALL-UNNAMED --add-exports=java.base/sun.nio.ch=ALL-UNNAMED --add-exports=jdk.unsupported/sun.misc=ALL-UNNAMED --add-exports=jdk.unsupported/sun.reflect=ALL-UNNAMED --add-modules=java.se --add-opens=java.desktop/com.sun.beans.introspect=ALL-UNNAMED --add-exports=java.desktop/com.sun.beans.util=ALL-UNNAMED

however, it seems the JdkPlugin does not work as a private static field of the java.beans.Introspector class called declaredMethodCache is accessed, but it does not exist anymore.

@NicklasWallgren
Copy link
Contributor

The JdkPlugin issue should hopefully be fixed as of https://github.com/HotswapProjects/HotswapAgent/pull/413/files

@skybber skybber closed this as completed Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants