Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

garble 0.10.1 #134961

Closed
wants to merge 1 commit into from
Closed

Conversation

chenrui333
Copy link
Member

Created by brew bump


Created with brew bump-formula-pr.

release notes
This bugfix release continues support for Go 1.20 and the upcoming 1.21, and features:
  • Avoid obfuscating local types used for reflection, like in go-spew - #765

@github-actions github-actions bot added go Go use is a significant feature of the PR or issue bump-formula-pr PR was created using `brew bump-formula-pr` labels Jun 26, 2023
@chenrui333
Copy link
Member Author

  ==> /opt/homebrew/Cellar/garble/0.10.1/bin/garble -literals -tiny build /private/tmp/garble-test-20230625-61452-1a418jr/hello.go
  # command-line-arguments
  cannot get modified linker: exit status 1:
  git: This shim is internal and must be run via brew.

@chenrui333 chenrui333 added the test failure CI fails while running the test-do block label Jun 26, 2023
@stefanb stefanb mentioned this pull request Jun 27, 2023
89 tasks
@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Jun 28, 2023
@cho-m
Copy link
Member

cho-m commented Jun 28, 2023

Homebrew test environment issue. Need to somehow get system git on PATH before the shim.

Homebrew ignores ENV.prepend_path "PATH", "/usr/bin".

Maybe with_env would work assuming it doesn't actually need to use the shim. Or Homebrew's git could work with ENV.prepend_path "PATH", Formula["git"].opt_bin. Not sure if there is an easier way.

@github-actions github-actions bot removed the stale No recent activity label Jun 28, 2023
@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Jun 30, 2023
@github-actions github-actions bot closed this Jul 2, 2023
@stefanb
Copy link
Member

stefanb commented Jul 20, 2023

@chenrui333 chenrui333 added the superseded PR was replaced by another PR label Jul 20, 2023
@chenrui333 chenrui333 deleted the bump-garble-0.10.1 branch January 22, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` go Go use is a significant feature of the PR or issue stale No recent activity superseded PR was replaced by another PR test failure CI fails while running the test-do block
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants