Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to send action and object #5

Merged
merged 3 commits into from
Jun 25, 2024
Merged

Allow to send action and object #5

merged 3 commits into from
Jun 25, 2024

Conversation

fjaeger
Copy link
Contributor

@fjaeger fjaeger commented Jun 24, 2024

Just a small improvement :)

High5Apps
High5Apps requested changes Jun 24, 2024
View reviewed changes
Copy link
Owner

@High5Apps High5Apps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey this change seems reasonable to me, but has some issues that must be addressed before merging. Please let me know if I can clarify anything

Sources/ACActionCable/ACCommand.swift Show resolved Hide resolved
Sources/ACActionCable/ACCommand.swift Outdated Show resolved Hide resolved
Sources/ACActionCable/ACSubscription.swift Outdated Show resolved Hide resolved
Sources/ACActionCable/ACSubscription.swift Outdated Show resolved Hide resolved
@High5Apps High5Apps merged commit 6285f4b into High5Apps:master Jun 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@High5Apps High5Apps High5Apps requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fjaeger @High5Apps