Merge pull request #2 from bobjacobsen/fixme_once

Fixme once
Hierosoft · Apr 15, 2024 · 1d6f1b0 · 1d6f1b0
2 parents 91b28bd + af9ebf3
commit 1d6f1b0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/openlcb/datagramservice.py b/openlcb/datagramservice.py
@@ -222,8 +222,7 @@ def handleDatagramRejected(self, message):
                 "Outstanding and replied-to memos don't match on rejected"
             )
 
-        currentOutstandingMemo = None
-        # FIXME: unused currentOutstandingMemo. Is any code incomplete here?
+        self.currentOutstandingMemo = None
 
         # fire the callback
         memo.rejectedReply(memo)
@@ -232,8 +231,7 @@ def handleDatagramRejected(self, message):
 
     def handleLinkQuiesce(self, message):
         '''Link quiesced before outage: stop operation'''
-        quiesced = True
-        # FIXME: unused quiesced. Is any code incomplete here?
+        self.quiesced = True
 
     def handleLinkRestarted(self, message):
         '''Link restarted after outage:

diff --git a/openlcb/tcplink/tcplink.py b/openlcb/tcplink/tcplink.py
@@ -145,8 +145,7 @@ def forwardMessage(self, messageBytes, gatewayNodeID) :  # not sure why gatewayN
         destNodeID = None
         data = messageBytes[8:]
         if mti.addressPresent() :
-            destNodeID = NodeID(messagePart[8:13])
-            # FIXME: ^ messagePart is undefined. Slice data or messageBytes?
+            destNodeID = NodeID(messageBytes[8:13])
             data = messageBytes[14:]
         # and finally create the message
         message = Message(mti, sourceNodeID, destNodeID, data)