Request filters Clickhouse #2372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chitalian
reviewed
Aug 15, 2024
web/services/hooks/requests.tsx
Outdated
| @@ -53,7 +77,55 @@ const useGetRequestsWithBodies = ( | |||
| }, | |||
| }); | |||
|
|
|||
| return response.data as Result<HeliconeRequest[], string>; | |||
| const result = response.data as Result<HeliconeRequest[], string>; | |||
There was a problem hiding this comment.
We dont want these changes
chitalian
reviewed
Aug 15, 2024
| @@ -34,7 +55,7 @@ export const getInitialColumns: ( | |||
| header: "Created At", | |||
| cell: (info) => ( | |||
| <span className="text-gray-900 dark:text-gray-100 font-medium"> | |||
| {getUSDateFromString(info.getValue() as string)} | |||
| {getUSDateFromString(convertToUSDateFormat(info.getValue() as string))} | |||
There was a problem hiding this comment.
Do we still need this or are we gunna do the +"z" hack?
chitalian
reviewed
Aug 15, 2024
web/lib/clients/jawnTypes/public.ts
Outdated
| @@ -23,6 +27,9 @@ export interface paths { | |||
| "/v1/request/query": { | |||
| post: operations["GetRequests"]; | |||
| }; | |||
| "/v1/request/queryClickhouse": { | |||
There was a problem hiding this comment.
I try not to camelcaseURLS
instead please use query-clickhouse
chitalian
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.