Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Dag screen to functional component #314

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

tuliomir
Copy link
Contributor

@tuliomir tuliomir commented Sep 6, 2024

Acceptance Criteria

  • The DAG screen should be refactored to functional component

Notes for reviewers

This screen relied heavily on local variables, instead of component state, to work. So the refactor had to change most of the data flow of this component. Many intermediate structures and helpers also had to be built, and this makes the diff almost unreadable.

I'd recommend looking at the file before and after to have a clearer understanding of the code changes.

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@tuliomir tuliomir merged commit da81453 into dev Sep 10, 2024
1 check passed
@tuliomir tuliomir deleted the refactor/dag-functional branch September 10, 2024 14:56
@tuliomir tuliomir mentioned this pull request Sep 17, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants