Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Automatic lint fixes and formatting #291

Merged
merged 3 commits into from
Aug 16, 2024
Merged

Conversation

tuliomir
Copy link
Contributor

@tuliomir tuliomir commented Aug 13, 2024

Acceptance Criteria

  • Applies all automatic formatting from prettier
  • Applies all automatic linting from lint --fix
  • Adds prettier formatting to the CI

Notes

Lint will not be added to the CI now as it requires many manual refactors before it could pass successfully.

As a reviewing reference, this PR is similar to the recent HathorNetwork/hathor-wallet-lib#670

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@tuliomir tuliomir self-assigned this Aug 13, 2024
@tuliomir tuliomir requested a review from r4mmer as a code owner August 13, 2024 22:44
@tuliomir tuliomir marked this pull request as draft August 13, 2024 22:45
Base automatically changed from feat/eslint to dev August 14, 2024 19:26
@tuliomir tuliomir marked this pull request as ready for review August 14, 2024 19:31
r4mmer
r4mmer previously approved these changes Aug 14, 2024
@tuliomir tuliomir merged commit b61769d into dev Aug 16, 2024
1 check passed
@tuliomir tuliomir deleted the style/lint-automatic branch August 16, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants