Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Caller should not connect on Rendezvous #2555

Closed
bpolic opened this issue Nov 25, 2022 · 2 comments
Closed

[BUG] Caller should not connect on Rendezvous #2555

bpolic opened this issue Nov 25, 2022 · 2 comments
Labels
[core] Area: Changes in SRT library core Type: Bug Indicates an unexpected problem or unintended behavior
Milestone

Comments

@bpolic
Copy link
Collaborator

bpolic commented Nov 25, 2022

Describe the bug
Caller can connect on Rendezvous

Linux machine 1 IP: yy.yy.yy.yy
Linux machine 2 IP: xx.xx.xx.xx

To Reproduce
Steps to reproduce the behavior:

  1. Use 2 Linux machines
  2. Build a SRT Library
  3. Run caller on first machine: ./srt-xtransmit receive "srt://xx.xx.xx.xx:8200?latency=500&bind=:8200" -v
  4. On another machine run rendezvous: ./srt-xtransmit generate "srt://yy.yy.yy.yy:8200?latency=500&mode=rendezvous&bind=:8200" -v --duration 20 --sendrate 5Mbps
  5. Current behavior: The connection has been established, and the data has been sent.

"Rendezvous-point received INDUCTION handshake (expected WAVEAHAND). Rejecting.
SOCKET::SRT 0x15F1BCC7 ASYNC Connected to srt://xx.xx.xx.xx:8200
17:20:34.310462 [I] PACER sendrate 5000000 bps (inter send interval 2105 us)"

Expected behavior
Caller should not connect on Rendezvous

Desktop (please provide the following information):

  • OS: Linux
  • SRT Version 1.5.1
@bpolic bpolic added the Type: Bug Indicates an unexpected problem or unintended behavior label Nov 25, 2022
@maxsharabayko
Copy link
Collaborator

This issue seems to be resolved in the latest master (6d62096).

./bin/srt-xtransmit receive "srt://127.0.0.1:4200?latency=500&bind=:5200" -v
10:30:57.456514 [I] SOCKET::SRT srt://127.0.0.1:4200: bound to ':5200'.
10:30:57.457216 [D] SOCKET::SRT 0x160BDB ASYNC Connecting to srt://127.0.0.1:4200
10:30:58.280427/*E:SRT.cn: @1444827: HS VERSION=5 but no handshake extension found!
10:30:58.280492/!W:SRT.cn: @1444827: processAsyncConnectRequest: REJECT reported from HS processing: Rogue peer or incorrect parameters - not processing further
10:30:58.283700 [D] SOCKET::SRT 0x160BDB connect failed. ERROR: Rogue peer or incorrect parameters.
10:30:58.283848 [D] SOCKET::SRT 0x160BDB Releasing epolls before closing
10:30:58.283888 [D] SOCKET::SRT 0x160BDB Closing
10:30:58.284024 [W] CONN connect failed: Rogue peer or incorrect parameters
./bin/srt-xtransmit generate "srt://127.0.0.1:5200?bind=:4200&mode=rendezvous" --duration 20s --sendrate 1Mbps -v
10:30:58.278782 [I] SOCKET::SRT srt://127.0.0.1:5200: bound to ':4200'.
10:30:58.279465 [D] SOCKET::SRT 0x2471F434 ASYNC Connecting to srt://127.0.0.1:5200
10:30:58.280608/*E:SRT.cn: @611447860: processConnectResponse: CONFUSED: expected UMSG_HANDSHAKE as connection not yet established, got: shutdown
10:30:58.280646/!W:SRT.cn: AsyncOrRND: PACKET NOT HANDSHAKE - re-requesting handshake from peer
10:31:28.296288 [D] SOCKET::SRT 0x2471F434 connect failed. ERROR: Rogue peer or incorrect parameters.
10:31:28.296491 [D] SOCKET::SRT 0x2471F434 Releasing epolls before closing
10:31:28.296549 [D] SOCKET::SRT 0x2471F434 Closing
10:31:28.296715 [W] CONN connect failed: Rogue peer or incorrect parameters

@maxsharabayko maxsharabayko added this to the v1.6.0 milestone Nov 28, 2022
@maxsharabayko maxsharabayko added the [core] Area: Changes in SRT library core label Nov 28, 2022
@maxsharabayko
Copy link
Collaborator

Looks like fixed by #2548.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core Type: Bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

2 participants