Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JarvisMarshArlorithm2D: must test for points starvation #4

Open
eplesse opened this issue Feb 22, 2021 · 0 comments
Open

JarvisMarshArlorithm2D: must test for points starvation #4

eplesse opened this issue Feb 22, 2021 · 0 comments

Comments

@eplesse
Copy link

eplesse commented Feb 22, 2021

Hello Erik. First, thanks for your great job . I mainly used your jarvisMarhsallAlgorithm2D. I wanted to raise your attention upon the following trap in which I have fallen quite often (I deal with hundrerds of various 2d Shapes points and need to build convex hull of each shape).
Even if I did not spent much time to understand precisely the algorithm, I had to change line 54 of JarvisMarchAlgorithm2D.cs like this:

 while (true && points.Count > 0)

Since all points may habe been removed by code at line 125
and that and radom access in points in made line 61

This has been enough for my needs but It might need your insight

Anyway, thanks again. This has been really usefull for me.

Emmanuel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant