Change uppercase DEBUG variables to lowercase debug

This is needed to avoid conflicting with the DEBUG CPP token.

I also changed one instance of debug to a 'parameter'. I left others as
is because I didn't do the analysis needed to confirm that they're never
set from elsewhere (because they are public to their modules).

Fixes ESCOMP#534

src/biogeophys/SurfaceRadiationMod.F90

@@ -25,7 +25,7 @@ module SurfaceRadiationMod
   implicit none
   private
 
-  logical :: DEBUG = .false.  ! for debugging this module
+  logical, parameter :: debug = .false.  ! for debugging this module
 
   !
   ! !PUBLIC MEMBER FUNCTIONS:
@@ -977,7 +977,7 @@ subroutine SurfaceRadiation(bounds, num_nourbanp, filter_nourbanp, &
           g = patch%gridcell(p)
 
           if(elai(p)==0.0_r8.and.fabd(p,1)>0._r8)then
-             if ( DEBUG ) write(iulog,*) 'absorption without LAI',elai(p),tlai(p),fabd(p,1),p
+             if ( debug ) write(iulog,*) 'absorption without LAI',elai(p),tlai(p),fabd(p,1),p
           endif
           ! Solar incident 
 

src/utils/clmfates_interfaceMod.F90

@@ -196,7 +196,7 @@ module CLMFatesInterfaceMod
    ! developer will at least question its usage (RGK)
    private :: hlm_bounds_to_fates_bounds
 
-   logical :: DEBUG  = .false.
+   logical :: debug  = .false.
 
    character(len=*), parameter, private :: sourcefile = &
         __FILE__
@@ -365,7 +365,7 @@ subroutine init(this, bounds_proc )
       ! Check through FATES parameters to see if all have been set
       call set_fates_ctrlparms('check_allset')
 
-      if(DEBUG)then
+      if(debug)then
          write(iulog,*) 'clm_fates%init():  allocating for ',nclumps,' threads'
       end if
 
@@ -400,15 +400,15 @@ subroutine init(this, bounds_proc )
                s = s + 1
                collist(s) = c
                this%f2hmap(nc)%hsites(c) = s
-               if(DEBUG)then
+               if(debug)then
                   write(iulog,*) 'clm_fates%init(): thread',nc,': found column',c,'with lu',l
                   write(iulog,*) 'LU type:', lun%itype(l)
                end if
             endif
 
          enddo
 
-         if(DEBUG)then
+         if(debug)then
             write(iulog,*) 'clm_fates%init(): thread',nc,': allocated ',s,' sites'
          end if
 

src/utils/clmfates_paraminterfaceMod.F90

@@ -15,7 +15,7 @@ module CLMFatesParamInterfaceMod
   private :: SetParameterDimensions
   private :: GetUsedDimensionSizes
 
-  logical :: DEBUG  = .false.
+  logical :: debug  = .false.
 
   character(len=*), parameter, private :: sourcefile = &
        __FILE__