Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

orientationMatch causes current_item to go out of sync #7

Open
GuySie opened this issue May 30, 2020 · 2 comments
Open

orientationMatch causes current_item to go out of sync #7

GuySie opened this issue May 30, 2020 · 2 comments

Comments

@GuySie
Copy link
Owner

GuySie commented May 30, 2020

If orientationMatch is enabled on the Canvas device, the device will automatically switch to an item in the right orientation when the orientation of the device changes. However, the current_item in gallery_status - which we use to detect when we need to get new item details - does not update when this happens. We currently reload the gallery when we detect an orientation change to force an update of current_item, but this can cause flickering or a change in displayed item on the device. It would be preferable to find a way to update current_item that is not visible to the user.

@GuySie GuySie changed the title orientationMatch causes current_item to go out of sync. orientationMatch causes current_item to go out of sync May 30, 2020
@GuySie
Copy link
Owner Author

GuySie commented Feb 13, 2022

Check if syncing the Meural also updates the current_item? If it does that would work better than reloading the gallery, which causes a visible flicker/change.

@GuySie
Copy link
Owner Author

GuySie commented Feb 13, 2022

Nope, syncing does not update the current_item :( apparently the Canvas itself isn't even aware that it is displaying another item entirely if orientationMatch changes it. Unless Meural fixes this, reloading the gallery is still the best solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant