Make use of recipe-scrapers for more generic web imports #18
Comments
|
I have a branch that does this. The import dialog was reworked to be a single dialog for file and web imports, with validation of the supported urls:
File import behaves the same. Web recipes are imported using
However, there's still a couple of items needing improvements:
The motivation for 1 is to be able to plug in more web importers in a homogeneous should the need arise, and to decouple the import mechanism from user feedback. web imports still take a few seconds, mostly related to retrieving the recipe image. As such, it would be beneficial to have the import status in an info bar, as file imports do it. |
|
To finalize this feature, an import status still needs to be implemented: recipes take a while to import, mostly due to retrieving and scaling images. |
|
Does this change mean that it will only be possible to import from one of the supported websites, rather than from any webpage with a recipe on it? I notice that the recipe scraper library has a sort of wild card option that may work on sites that are not directly supported |
|
I would have preferred to support these websites indeed, but it's not realistic. I would prioritise I like your suggesting of importing recipes by pasting selected text (or recipe file) in a window (the main window?). I will prototype something and ask for your feedback :) |
|
@cydanil Someone made a wrapper to text parsing here: hhursev/recipe-scrapers#9 (comment) Maybe that can be utilized? |
|
Thanks for pointing me towards this comment, @founderio. However, it seems to still expect SchemaOrg content. I picture the imports to be unstructured text as some variation of what's below: text = """
<html>
<title>Recipe title </title>
<br/>
Ingredients:
Ingredient Group 1:
1 ⅓ cups all-purpose flour
1 tablespoon granulated sugar
½ teaspoon salt
½ cup shortening
3 ½ tablespoons cold water
Ingredient Group 2:
2 cups mashed, cooked pumpkin, or about 1 1/2 pounds skin-on, raw pumpkin; Shortcut: You can substitute with canned pumpkin. Before you buy, you should check the label to make sure of what's in the can; if it's labeled "pumpkin pie filling" it's already spiced. If you plan to sweeten yourself with the ingredients below, go for unflavored canned pumpkin.
1 (12 fluid ounce) can evaporated milk
2 eggs, beaten
¾ cup packed brown sugar
½ teaspoon ground cinnamon
½ teaspoon ground ginger
½ teaspoon ground nutmeg
½ teaspoon salt
<br/>
whole pumpkin for pie
1. Instructions Part 1
blabla
2. Instructions Part 2
text
3. Instruction Part 3
text
</html>
""" |
I have just realised that the traditional importer (i.e. with the text pane and all the tag buttons on the right) almost does this now. |
|
I've been experimenting with drag and drop and pasting.
What do you think? |
|
This looks great! |
|
This has been finalized in #67, where there's a couple of screencasts demonstrating drag and drop, similar to copy/paste. I appreciate that supporting only a set of website looks like a regression in terms of functionality, even though it's compensated by plain text import. Thanks for your feedback and ideas! |
https://github.com/hhursev/recipe-scrapers provides a nice interface to scrape a number of websites, which could replace our importers for more flexible imports.
This would also remove the burden for us to maintain importers on top of the application itself, as well as support way more websites than we could.
The text was updated successfully, but these errors were encountered: