Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update google.golang.org/api version to get NEG IPv6 fields #89

Merged
merged 4 commits into from
Mar 28, 2023

Conversation

gauravkghildiyal
Copy link
Member

No description provided.

@google-oss-prow
Copy link
Contributor

Hi @gauravkghildiyal. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spencerhance
Copy link
Member

/ok-to-test

@gauravkghildiyal
Copy link
Member Author

/hold

@gauravkghildiyal
Copy link
Member Author

There's some test failures upstream. Will wait for them to get fixed.

@gauravkghildiyal gauravkghildiyal changed the title Update google.golang.org/api version to get NEG ipv6 fields Update google.golang.org/api version to get NEG IPv6 fields Mar 25, 2023
@gauravkghildiyal
Copy link
Member Author

/unhold

@gauravkghildiyal
Copy link
Member Author

/retest

@gauravkghildiyal
Copy link
Member Author

Looks like pull-k8s-cloud-provider-test uses a very old version of golang.

For starters, I'll update this to a new image.

@aojea
Copy link

aojea commented Mar 27, 2023

Looks like pull-k8s-cloud-provider-test uses a very old version of golang.

I think that the problem is that there some dependencies that needs to be updated too

go.mod Outdated
@@ -30,6 +30,6 @@ replace (
golang.org/x/net => golang.org/x/net v0.0.0-20210503060351-7fd8e65b6420
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should not need to use these replace block, replace is for pinning dependencies

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you try to remove the entire replace block and run go mod tidy && go mod vendor again?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

>you should not need to use these replace block, replace is for pinning dependencies
While I'm not aware of the context of why that was done, but I did see a commit from @spencerhance to explicitly pin them. Spencer, can you clarify if this is still needed?

>can you try to remove the entire replace block and run go mod tidy && go mod vendor again?
Gave this a shot. It failed with another reason. I believe the explanation in #89 (comment) should be the cause for this too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably don't need to pin dependencies anymore. We originally did this when we first migrated to go modules to make sure that dependencies wouldn't get updated.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Spencer! I removed the pinned dependencies.

@gauravkghildiyal
Copy link
Member Author

Thanks for looking into this Antonio!

I tried running the tests locally and they pass for me without any additional changes.

Why I believed it was the older go version was because the error messages are complaining about objects not found in the go standard library:
image

Looks like these were initially available in the ioutil package but then deprecated and moved to the io package in go1.16. We're using kubekins-e2e image from 2019 and looks like go1.16 wasn't released then:
image

@gauravkghildiyal
Copy link
Member Author

/retest

@aojea
Copy link

aojea commented Mar 27, 2023

Looks like these were initially available in the ioutil package but then deprecated and moved to the io package in go1.16. We're using kubekins-e2e image from 2019 and looks like go1.16 wasn't released then:

:/

@gauravkghildiyal
Copy link
Member Author

/retest

@bowei
Copy link
Member

bowei commented Mar 28, 2023

Gaurav -- can you update and rerun to regenerate the changed files.

@gauravkghildiyal
Copy link
Member Author

@bowei

Gaurav -- can you update and rerun to regenerate the changed files.

Done

@aojea
Copy link

aojea commented Mar 28, 2023

LGTM

@bowei
Copy link
Member

bowei commented Mar 28, 2023

/lgtm
/approve

@google-oss-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, gauravkghildiyal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit ca30b32 into GoogleCloudPlatform:master Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants