-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update google.golang.org/api version to get NEG IPv6 fields #89
Update google.golang.org/api version to get NEG IPv6 fields #89
Conversation
Hi @gauravkghildiyal. Thanks for your PR. I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/hold |
There's some test failures upstream. Will wait for them to get fixed. |
bec0579
to
3ffe0b6
Compare
/unhold |
/retest |
Looks like For starters, I'll update this to a new image. |
I think that the problem is that there some dependencies that needs to be updated too |
go.mod
Outdated
@@ -30,6 +30,6 @@ replace ( | |||
golang.org/x/net => golang.org/x/net v0.0.0-20210503060351-7fd8e65b6420 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should not need to use these replace block, replace is for pinning dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you try to remove the entire replace
block and run go mod tidy && go mod vendor
again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
>you should not need to use these replace block, replace is for pinning dependencies
While I'm not aware of the context of why that was done, but I did see a commit from @spencerhance to explicitly pin them. Spencer, can you clarify if this is still needed?
>can you try to remove the entire replace block and run go mod tidy && go mod vendor again?
Gave this a shot. It failed with another reason. I believe the explanation in #89 (comment) should be the cause for this too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably don't need to pin dependencies anymore. We originally did this when we first migrated to go modules to make sure that dependencies wouldn't get updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Spencer! I removed the pinned dependencies.
/retest |
:/ |
de43b3b
to
3ffe0b6
Compare
/retest |
3ffe0b6
to
b0edbab
Compare
Gaurav -- can you update and rerun to regenerate the changed files. |
b0edbab
to
cbaa3f6
Compare
Done |
LGTM |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bowei, gauravkghildiyal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.