Adds global OperationsUseWait which switches Operation.Get to Operation.Wait; manual e2e testing #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowei
force-pushed
the
wait
branch
2 times, most recently
from
cf39f80
to
d891abc
Compare
bowei
changed the title
krzykwas
reviewed
Mar 24, 2023
krzykwas
reviewed
Mar 24, 2023
krzykwas
reviewed
Mar 24, 2023
e2e/testmain_test.go
Outdated
| } | ||
| } | ||
|
|
||
| // deleteAllResources attempts to remove all resources that may have |
There was a problem hiding this comment.
Not used, should it be deleted?
krzykwas
approved these changes
Mar 24, 2023
aojea
reviewed
Mar 24, 2023
briantkennedy
approved these changes
Mar 24, 2023
bowei
changed the title
…on.Wait This flag is temporary. After soaking testing, we should be able to remove the Get() path.
|
Updated |
briantkennedy
approved these changes
Mar 28, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bowei, briantkennedy, krzykwas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds global OperationsUseWait which switches Operation.Get to Operation.Wait
This flag is temporary. After soaking testing, we should be able to remove the Get() path.
Also adds some manual e2e tests in the e2e/ directory.