fix: Add functools.wraps decorator #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make sure function attributes are copied to `_http_view_func_wrapper`
svleeuwen
changed the title
|
It seems the unit test failures are related to this PR, though it's unclear to me why the change is causing cloudevent functions to fail... |
|
@anniefu that test is also failing in master, so it's indeed not caused by this change. |
|
Hmm, it seems one of our dependency libraries has changed their error message causing an assertion to fail. I'll take a pass at fixing it up. Thanks for your patience. |
anniefu
approved these changes
May 3, 2022
|
Hey @svleeuwen, I've fixed the tests up and rebased the PR. Do you have the ability to merge this? I can do it otherwise. Thanks again for the contribution! |
|
@anniefu I don't have write access so I can't merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make sure function attributes are copied to
_http_view_func_wrapper