Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update README to use declarative function signatures #171

Merged
merged 2 commits into from
Dec 1, 2021

Conversation

anniefu
Copy link
Contributor

@anniefu anniefu commented Nov 23, 2021

Reduce redundancy in quickstart examples.

Reduce redundancy in quickstart examples.
README.md Outdated Show resolved Hide resolved
Comment on lines +118 to +119
-H "Content-Type: application/cloudevents+json" \
-d '{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: mix of " and ' chars.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was intentional to differentiate the JSON and the beginning/end of the data blob for the terminal

README.md Show resolved Hide resolved
@anniefu anniefu requested a review from grant November 23, 2021 17:23
@anniefu anniefu merged commit efb0e84 into GoogleCloudPlatform:master Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants