Skip to content
This repository has been archived by the owner on Jan 23, 2021. It is now read-only.

Remove the hash fragment the URL when determining if there's a match. #291

Merged
merged 1 commit into from
May 4, 2017

Conversation

jeffposnick
Copy link
Contributor

Copy link

@gauntface gauntface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be a seperate input parameter or just part of the url tweaking outside of the strip search param function?

@jeffposnick
Copy link
Contributor Author

jeffposnick commented May 2, 2017

I think that's the right place to the tweaking, since we're already constructing the URL object and manipulating it there. What if I renamed the function from stripIgnoredUrlParameters to cleanUrl or something like that to reflect the fact that it's doing more than manipulating the search value?

It doesn't need a parameter to toggle the behavior. The hash should be unconditionally stripped.

@jeffposnick jeffposnick merged commit da6d750 into master May 4, 2017
@jeffposnick jeffposnick deleted the ignore-hash-fragment branch May 4, 2017 19:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants