Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image aspect ratio test is too strict? #15326

Closed
2 tasks done
djmj opened this issue Aug 2, 2023 · 0 comments · Fixed by #15328
Closed
2 tasks done

Image aspect ratio test is too strict? #15326

djmj opened this issue Aug 2, 2023 · 0 comments · Fixed by #15328
Assignees

Comments

@djmj
Copy link

djmj commented Aug 2, 2023

FAQ

URL

https://www.call4drinks.de/c/Cola-Colamixgetr%C3%A4nke

What happened?

Testing the above URL it says the product image ratios are incorrect:

Original: 63 x 256 (0.25)
Shown: 32 x 128 (0.25)

Its impossible to scale the original image correctly since the original width is 63 pixel which is not dividable without fractional part.

The image aspect ratio should be aware of this. If the rounded aspect ratio with 2 fractional digits of original and shown image are equal it should be measured equal and correct.

The original aspect ratio in this example is: 0.24609 rounded to 0.25

google pagespeed - image aspect ratio

What did you expect?

The aspect ratios of 0.25 are identical so the test result is not correct.

What have you tried?

No response

How were you running Lighthouse?

PageSpeed Insights

Lighthouse Version

10.3.0

Chrome Version

No response

Node Version

No response

OS

No response

Relevant log output

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants