Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is $__node_harmony needed in extension? #1508

Closed
XhmikosR opened this issue Jan 22, 2017 · 4 comments
Closed

Is $__node_harmony needed in extension? #1508

XhmikosR opened this issue Jan 22, 2017 · 4 comments
Labels

Comments

@XhmikosR
Copy link
Contributor

XhmikosR commented Jan 22, 2017

It's causing issues when building on Windows so I wonder if it's needed for the extension.

Also, would be nice if the package.json engines values were consistent across all package.json files.

@wardpeet
Copy link
Collaborator

no because it's being build as a package. It depends on what version @brendankenny is publishing :)

@XhmikosR
Copy link
Contributor Author

By no, you mean that the flag isn't needed? Because if that's the case, it's one thing closer to proper Windows support :)

@XhmikosR
Copy link
Contributor Author

It is still needed for the extension :/

@ebidel
Copy link
Contributor

ebidel commented Jan 24, 2017

As of #1519, this will no longer be needed.

@ebidel ebidel closed this as completed Jan 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants