Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve registry mod #84

Merged
merged 2 commits into from
Sep 27, 2017
Merged

Improve registry mod #84

merged 2 commits into from
Sep 27, 2017

Conversation

snakems
Copy link
Contributor

@snakems snakems commented Sep 25, 2017

Improve registry mod
Fix print

Improve registry mod
Fix print
@obilodeau
Copy link
Member

Thanks @snakems!

@Svieg do you see any disadvantage of creating missing registry paths like this patch does?

@@ -501,6 +501,9 @@ def registry(profile_name, reg_mod, fd):
Adds a registry key modification to a profile with PowerShell commands.
"""
if reg_mod["modtype"] == "add":
reg_key_line = 'if ( -not (Test-Path "{0}") ){{New-Item "{0}" -Force}}\r\n' \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment here like:

# Creates registry path if it doesn't exist

Thanks!

@obilodeau obilodeau merged commit 029d76f into GoSecure:master Sep 27, 2017
@snakems snakems deleted the registry_mod_fix branch September 28, 2017 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants