More flexible configuration and small bonuses #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way we can leverage packer's packer_cache/ directory and not clutter the location the user is working from. Generated vagrant box is also in the user's cache directory and `vagrant box add` was updated to fetch box from cache directory as well
Also fixed a small terminology mistach: vagrant import vs vagrant box add
* config.js is now a javascript file that gets minified into a json file by malboxes * Comments are thus allowed and used to enable or disable features (IDA debuggers and Tools uploads) * Packer template file is built based on features enabled or disabled * Removed duplication in packer profiles
|
Upon first read, I think it looks nice. I'll test it asap and get back to you ! |
obilodeau
changed the title
* Allows for logic to be kept outside of Python code making customization and contributions easier * Ported profile tests to Python and doing a Jinja test and a json test
obilodeau
changed the title
|
Looks good to me ! You can merge if you want, works on every windows version we support ? |
| * Uncomment a specific section of the file to trigger a particular feature. | ||
| * | ||
| * Paths should be written using forward slashes even on Windows. | ||
| * For ex: C:/Tools |
There was a problem hiding this comment.
Yeah, tab vs spaces issue... It's fixed in the other branch I'm about to push so I won't fix it here in order to avoid conflicts.
Tested on Windows 10 64 bits only. I don't have a Win 7 VM handy due to hard drive space limits (and too many vagrant boxes as I test things). I can't see why Win 7 wouldn't work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits for list of changes.
Small bonuses:
packer_cache/is reused)tools_pathinC:\ToolsThis is ready although not tested on Windows where my nested VMs configuration doesn't pass the
packer buildphase.