-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More flexible configuration and small bonuses #8
Conversation
This way we can leverage packer's packer_cache/ directory and not clutter the location the user is working from. Generated vagrant box is also in the user's cache directory and `vagrant box add` was updated to fetch box from cache directory as well
Also fixed a small terminology mistach: vagrant import vs vagrant box add
* config.js is now a javascript file that gets minified into a json file by malboxes * Comments are thus allowed and used to enable or disable features (IDA debuggers and Tools uploads) * Packer template file is built based on features enabled or disabled * Removed duplication in packer profiles
Upon first read, I think it looks nice. I'll test it asap and get back to you ! |
* Allows for logic to be kept outside of Python code making customization and contributions easier * Ported profile tests to Python and doing a Jinja test and a json test
Looks good to me ! You can merge if you want, works on every windows version we support ? |
* Uncomment a specific section of the file to trigger a particular feature. | ||
* | ||
* Paths should be written using forward slashes even on Windows. | ||
* For ex: C:/Tools |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
weird indent ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, tab vs spaces issue... It's fixed in the other branch I'm about to push so I won't fix it here in order to avoid conflicts.
Tested on Windows 10 64 bits only. I don't have a Win 7 VM handy due to hard drive space limits (and too many vagrant boxes as I test things). I can't see why Win 7 wouldn't work. |
See individual commits for list of changes.
Small bonuses:
packer_cache/
is reused)tools_path
inC:\Tools
This is ready although not tested on Windows where my nested VMs configuration doesn't pass the
packer build
phase.